[139991] trunk/dports/lang

[Ryan Schmidt]

On Sep 5, 2015, at 9:39 AM, takeshi at macports.org wrote:
> 
> Revision
> 139991
> Author
> takeshi at macports.org
> Date
> 2015-09-05 07:39:36 -0700 (Sat, 05 Sep 2015)
> Log Message
> 
> fpc: add to MacPorts

> Added: trunk/dports/lang/fpc/Portfile (0 => 139991)

> +if {${os.major} > 13} {
> +    build.args      MACOSX_DEPLOYMENT_TARGET='10.9'
> +    destroot.args   ${build.args}
> +}

What is the reason for these lines? MacPorts already sets MACOSX_DEPLOYMENT_TARGET as an environment variable in all phases, to the value of the ${macosx_deployment_target} variable. By default, the value of that variable is the OS X major version of the build machine. If the reason for this change is that the build system does not work correctly when MACOSX_DEPLOYMENT_TARGET is set to 10.10 or later, then the better way to accomplish setting it to 10.9 would be to change the macosx_deployment_target variable. Also, it wouldn't hurt to check that the OS is OS X first.

platform darwin {
    if {${os.major} > 13} {
        macosx_deployment_target 10.9
    }
}

It would be a good idea to add a comment to the portfile explaining why these lines are there. For example, if an error occurs during the build on 10.10 without these lines, add a comment containing that error message. That way, somebody experiencing that error might be able to find your solution through a search.