Inconsistent criteria of success on the buildbot

[Joshua Root]

On 2016-2-25 18:18 , Mojca Miklavec wrote:
> Hi,
>
> A while ago I committed a new subport for geant4.10.2 which is
> currently broken (in the meantime I lacked time/motivation to look
> into it; and nobody else complained so far either):
>      https://trac.macports.org/ticket/50426
>
> The initial builds failed, see for example:
>      https://build.macports.org/builders/buildports-mtln-x86_64/builds/27442
> but judging from
>      http://packages.macports.org/geant4.10.2/
> it seems as if the "build all ports" picked up and uploaded the
> "broken" package with "no questions asked".
>
> Shouldn't this be fixed somehow? (Not just the port, but also the
> behaviour.) Or did the package automagically start to work properly?
>
> I don't dare to even start parsing the logs from the all-ports build.
> The progress log from the same buildslave
>      https://build.macports.org/builders/buildports-mtln-x86_64/builds/28037/steps/compile/logs/progress
> says "package found, not building again".

That happens if installation succeeded but activation failed, or 
rev-upgrade failed afterwards. What behaviour are you wanting? For it to 
uninstall the port in this case?

I agree it's not really ideal, but it does speed things up for users as 
archives are intended to do, even though in this case what they end up 
with is broken either way. And you'll need a version or revision bump to 
fix it, so uninstalling and attempting the build again in future doesn't 
really help.

- Josh