[144322] trunk/dports/python/py-keyczar/Portfile

[Ryan Schmidt]

> On Jan 6, 2016, at 10:12 AM, adfernandes at macports.org wrote:
> 
> Revision
> 144322
> Author
> adfernandes at macports.org
> Date
> 2016-01-06 08:12:47 -0800 (Wed, 06 Jan 2016)
> Log Message
> 
> python/py-keyczar: fix portfile for silent failures that only buildbot showed (grr)
> Modified Paths
> 
> 	• trunk/dports/python/py-keyczar/Portfile
> Diff
> 
> Modified: trunk/dports/python/py-keyczar/Portfile (144321 => 144322)

> +github.setup        google keyczar Python_release_0.715
> +
> +regexp {([^_]+)$} ${version} version

This is not the correct usage of the github portgroup. The correct usage is:

github.setup        google keyczar 0.715 Python_release_


> +fetch.type          git

Why must it fetch from git?


> +worksrcdir          python-keyczar-Python_release_${version}

Once the usage of github.setup is corrected as above, this line should be unnecessary.


> +build.cmd           cd python && ${python.bin} setup.py --no-user-cfg
> +destroot.cmd        cd python && ${python.bin} setup.py --no-user-cfg

Using "cd" in a build.cmd/destroot.cmd is unusual. Is there a reason why you didn't instead set build.dir?