[144322] trunk/dports/python/py-keyczar/Portfile

[Ryan Schmidt]

On Jan 7, 2016, at 8:39 AM, Andrew Fernandes wrote:

>> This is not the correct usage of the github portgroup. The correct usage is:
>> 
>> github.setup        google keyczar 0.715 Python_release_
> 
> Ah. Of course. I’m so used to looking and seeing a ‘v’ for a prefix, I overlooked the obvious.
> 
>> Why must it fetch from git?
> 
> Because I couldn’t get it to fetch the tarball; that’s fixed now.
> 
>> Once the usage of github.setup is corrected as above, this line should be unnecessary.
> 
> Done.
> 
>>> +build.cmd           cd python && ${python.bin} setup.py --no-user-cfg
>>> +destroot.cmd        cd python && ${python.bin} setup.py --no-user-cfg
>> 
>> Using "cd" in a build.cmd/destroot.cmd is unusual. Is there a reason why you didn't instead set build.dir?
> 
> Yes, because it doesn’t work.
> 
> The python code is built in a subdirectory of the tarball, and I looked and looked, and that seemed to be the only way to do it.

I tried replacing those two lines with:

build.dir           ${worksrcpath}/python

and it seemed to build ok. Does that work for you?



> Committing the fixes as you suggested now.
> 
> -A.