Pull Requests for Work in Progress (WIP)

Marko Käning mk-macports at posteo.net
Fri Nov 4 11:04:49 PDT 2016


On 04 Nov 2016, at 02:19 , Arno Hautala <arno at alum.wpi.edu> wrote:
> But, it occurs to me that one of the goals of moving
> to GitHub is greater collaboration and that is facilitated by inline
> comments on the pull request. Plus, a completed pull request is one
> comment away from a work in progress anyway.

+1


> The alternative to WiP pull requests is posting multiple comparison
> URLs to reference different lines of code that must be opened in
> different windows. Plus, those references will break as soon as any
> changes are made to the branch.

Exactly, I don’t think this is the way to go.

But let’s those decide who would have to deal (or not) with those red “WIP” badges in GitHub PR interface every now and then...

Well, if it is too much red noise in the PR interface then one would have to have these discussions directly on the contributors’ private forks of the macports-ports.
Downside there: If one decides to kill one of these repos all their comments to the relevant code are gone. So, that’s perhaps an argument more for keeping WIP PRs?


More information about the macports-dev mailing list