[153120] trunk/dports/fuse/sshfs

[Joshua Root]

On 2016-9-26 18:18 , Ryan Schmidt wrote:
>
>> On Sep 24, 2016, at 8:57 PM, dports at macports.org wrote:
>>
>> +# fix g_slice_set_config error (#52347)
>> +patch_sites         https://github.com/libfuse/sshfs/commit/
>>
>> +patchfiles-append   e5acfce8eda218d.patch
>
>
> We usually reserve the use of externally-hosted patchfiles for those that are large and/or maintained elsewhere (for example, the PHP Suhosin patch). But this is a one-line patch to the upstream sources, which means it will be in the next release, and this patchfile should have been copied into the port's files directory instead. You can add a comment to the top of the patchfile with the URL you got it from, for example:
>
> https://trac.macports.org/browser/trunk/dports/audio/taglib-extras/files/patch-cmake-modules-FindTaglib.cmake.diff?rev=153168
>
> No need to change it now since it's working, but keep it in mind for future commits.

I really don't see a problem with using patch_sites for any patches that 
are available for download somewhere stable. In fact it's even slightly 
preferable because it avoids the extra work of adding the file and 
adding a comment like you mentioned, plus it reduces the size of the 
ports tree.

- Josh