[macports-ports] 03/06: cxx11 PG: do not force the use of depends_lib-append

Marcus Calhoun-Lopez mcalhoun at macports.org
Fri Dec 8 05:54:56 UTC 2017


On Thu, Dec 7, 2017 at 9:37 PM, Joshua Root <jmr at macports.org> wrote:
> On 2017-12-8 10:01 , Marcus Calhoun-Lopez wrote:
>> On Mon, Dec 4, 2017 at 10:23 PM, Ryan Schmidt <ryandesign at macports.org> wrote:
>>>
>>> Also, why `global os.major`? It's not used...
>> os.major is used in line 52 [1].
>
> But not inside the register_gcc_dependents (now cxx11.add_dependencies)
> proc.

As far as I can tell, cxx11.add_dependencies (formally
register_gcc_dependents) begins on line 47 [1] and ends on line 58
[2].
os.major is used in line 52 [3].
Doesn't that put it within the procedure?
And doesn't that in turn necessitate the statement `global os.major`
on line 48 [4]?

Please forgive me if I am missing something obvious.

-Marcus

[1] https://github.com/macports/macports-ports/blob/443d1ccb2dedd2ab97bf354437473c11950936f2/_resources/port1.0/group/cxx11-1.1.tcl#L47
[2] https://github.com/macports/macports-ports/blob/443d1ccb2dedd2ab97bf354437473c11950936f2/_resources/port1.0/group/cxx11-1.1.tcl#L58
[3] https://github.com/macports/macports-ports/blob/443d1ccb2dedd2ab97bf354437473c11950936f2/_resources/port1.0/group/cxx11-1.1.tcl#L52
[4] https://github.com/macports/macports-ports/blob/443d1ccb2dedd2ab97bf354437473c11950936f2/_resources/port1.0/group/cxx11-1.1.tcl#L48


More information about the macports-dev mailing list