[macports-ports] 03/06: cxx11 PG: do not force the use of depends_lib-append

Joshua Root jmr at macports.org
Fri Dec 8 06:56:26 UTC 2017


On 2017-12-8 16:54 , Marcus Calhoun-Lopez wrote:
> On Thu, Dec 7, 2017 at 9:37 PM, Joshua Root <jmr at macports.org> wrote:
>> On 2017-12-8 10:01 , Marcus Calhoun-Lopez wrote:
>>> On Mon, Dec 4, 2017 at 10:23 PM, Ryan Schmidt <ryandesign at macports.org> wrote:
>>>>
>>>> Also, why `global os.major`? It's not used...
>>> os.major is used in line 52 [1].
>>
>> But not inside the register_gcc_dependents (now cxx11.add_dependencies)
>> proc.
> 
> As far as I can tell, cxx11.add_dependencies (formally
> register_gcc_dependents) begins on line 47 [1] and ends on line 58
> [2].
> os.major is used in line 52 [3].
> Doesn't that put it within the procedure?
> And doesn't that in turn necessitate the statement `global os.major`
> on line 48 [4]?
> 
> Please forgive me if I am missing something obvious.

I see, it is used now. It wasn't in the commit that Ryan was commenting
on. Sorry for the confusion. :)

- Josh


More information about the macports-dev mailing list