Pull request types in template on GitHub
mojca at macports.org
Tue Sep 12 23:40:47 UTC 2017
10. sep. 2017 16:28 "Rainer Müller" <raimue at macports.org>:
our GitHub pull request template  contains the following snippet
which is used by the macportsbot to assign the corresponding label to it.
<!-- update (title contains ": U(u)pdate to"), submission (new Portfile)
and CVE Identifiers are auto-detected, replace [ ] with [x] to select -->
- [ ] bugfix
- [ ] enhancement
- [ ] security fix
However, GitHub interpretes this as a list of tasks. This means that
with that list alone with one entry selected, the pull request will be
displayed with the note "1 of 3" and a progress bar next to it in the
list of pull requests.
I started ignoring the counter. There are other points that often don't
make sense like whether the tests were run when none are available (yet).
It is more valuable to me to see explicitly that they were not that to
hide/obfuscate that fact.
We could delete the non-applicable categories, I just wanted to say that I
don't care that much.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the macports-dev