[macports-ports] 01/02: hunspell-en: SCOWL based hunspell dictionary for en_AU, en_CA, en_GB, and en_US

[Ryan Schmidt]

On Sep 26, 2017, at 10:29, Marius Schamschula wrote:

> On Sep 26, 2017, at 9:36 AM, Ryan Schmidt wrote:
> 
>> On Sep 25, 2017, at 20:19, Marius Schamschula wrote:

>>> +variant en_GB_ise description {GB-ise English dictionary} {
>>> +    destroot {
>>> +        xinstall -m 644 ${worksrcpath}/speller/en_GB-ise.aff $installdir
>>> +        xinstall -m 644 ${worksrcpath}/speller/en_GB-ise.dic $installdir
>>> +    }
>>> +}
>>> +
>>> +variant en_GB_ize description {GB-ize English dictionary} {
>>> +    destroot {
>>> +        xinstall -m 644 ${worksrcpath}/speller/en_GB-ize.aff $installdir
>>> +        xinstall -m 644 ${worksrcpath}/speller/en_GB-ize.dic $installdir
>>> +    }
>>> +}
>>> +
>>> +variant en_GBS_large description {GB English dictionary (large)} {
>>> +    destroot {
>>> +        xinstall -m 644 ${worksrcpath}/speller/en_GB-large.aff $installdir
>>> +        xinstall -m 644 ${worksrcpath}/speller/en_GB-large.dic $installdir
>>> +    }
>>> +}


>> Each of the variants overrides the destroot phase with a custom block. What happens if the user selects more than one variant? Which variant's destroot block gets used? Perhaps you meant to use a post-destroot block instead. What happens if the user deselects all variants? I suspect it will fail at the destroot phase.
>> 
>> 
>> Note that you can install multiple files in a single xinstall invocation, e.g.:
>> 
>> xinstall -m 644 -W ${worksrcpath}/speller en_US-large.aff en_US-large.dic $installdir
> 
> Good catch, as I’ve only installed the default variant, I’ll fix it today.

Also, I just see now, is the variant name "en_GBS_large" intentional or should it be "en_GB_large"?