[macports-ports] 01/02: hunspell-en: SCOWL based hunspell dictionary for en_AU, en_CA, en_GB, and en_US

[Ryan Schmidt]

On Sep 25, 2017, at 20:19, Marius Schamschula wrote:

> Marius Schamschula (Schamschula) pushed a commit to branch master
> in repository macports-ports.
> 
> 
> https://github.com/macports/macports-ports/commit/2c63e3665450bf4a651dbb5b39c902a1a378c397
> 
> commit 2c63e3665450bf4a651dbb5b39c902a1a378c397
> 
> Author: Marius Schamschula <mps at macports.org>
> AuthorDate: Mon Sep 25 20:17:03 2017 -0500
> 
> 
>     hunspell-en: SCOWL based hunspell dictionary for en_AU, en_CA, en_GB, and en_US


> +pre-destroot {
> +    xinstall -d -m 755 $installdir
> +}
> +
> +variant en_AU description {US English dictionary} {
> +    destroot {
> +        xinstall -m 644 ${worksrcpath}/speller/en_AU.aff $installdir
> +        xinstall -m 644 ${worksrcpath}/speller/en_AU.dic $installdir
> +    }
> +}
> +
> +variant en_AU_large description {US English dictionary (large)} {
> +    destroot {
> +        xinstall -m 644 ${worksrcpath}/speller/en_AU-large.aff $installdir
> +        xinstall -m 644 ${worksrcpath}/speller/en_AU-large.dic $installdir
> +    }
> +}
> +
> +variant en_CA description {CA English dictionary} {
> +    destroot {
> +        xinstall -m 644 ${worksrcpath}/speller/en_CA.aff $installdir
> +        xinstall -m 644 ${worksrcpath}/speller/en_CA.dic $installdir
> +    }
> +}
> +
> +variant en_CA_large description {CA English dictionary (large)} {
> +    destroot {
> +        xinstall -m 644 ${worksrcpath}/speller/en_CA-large.aff $installdir
> +        xinstall -m 644 ${worksrcpath}/speller/en_CA-large.dic $installdir
> +    }
> +}
> +
> +variant en_GB_ise description {GB-ise English dictionary} {
> +    destroot {
> +        xinstall -m 644 ${worksrcpath}/speller/en_GB-ise.aff $installdir
> +        xinstall -m 644 ${worksrcpath}/speller/en_GB-ise.dic $installdir
> +    }
> +}
> +
> +variant en_GB_ize description {GB-ize English dictionary} {
> +    destroot {
> +        xinstall -m 644 ${worksrcpath}/speller/en_GB-ize.aff $installdir
> +        xinstall -m 644 ${worksrcpath}/speller/en_GB-ize.dic $installdir
> +    }
> +}
> +
> +variant en_GBS_large description {GB English dictionary (large)} {
> +    destroot {
> +        xinstall -m 644 ${worksrcpath}/speller/en_GB-large.aff $installdir
> +        xinstall -m 644 ${worksrcpath}/speller/en_GB-large.dic $installdir
> +    }
> +}
> +
> +variant en_US description {US English dictionary} {
> +    destroot {
> +        xinstall -m 644 ${worksrcpath}/speller/en_US.aff $installdir
> +        xinstall -m 644 ${worksrcpath}/speller/en_US.dic $installdir
> +    }
> +}
> +
> +variant en_US_large description {US English dictionary (large)} {
> +    destroot {
> +        xinstall -m 644 ${worksrcpath}/speller/en_US-large.aff $installdir
> +        xinstall -m 644 ${worksrcpath}/speller/en_US-large.dic $installdir
> +    }
> +}
> +
> +default_variants +en_US

Each of the variants overrides the destroot phase with a custom block. What happens if the user selects more than one variant? Which variant's destroot block gets used? Perhaps you meant to use a post-destroot block instead. What happens if the user deselects all variants? I suspect it will fail at the destroot phase.


Note that you can install multiple files in a single xinstall invocation, e.g.:

xinstall -m 644 -W ${worksrcpath}/speller en_US-large.aff en_US-large.dic $installdir