[macports-ports] branch master updated: exiftran: Update to version 2.14

Ryan Schmidt ryandesign at macports.org
Thu Sep 28 19:54:09 UTC 2017


On Sep 28, 2017, at 10:30, Rainer Müller wrote:

> Rainer Müller (raimue) pushed a commit to branch master
> in repository macports-ports.
> 
> 
> https://github.com/macports/macports-ports/commit/6b9c2b3be6d98ab37602690a9449bb688a0699e8
> 
> The following commit(s) were added to refs/heads/master by this push:
> 
>      new 6b9c2b3  exiftran: Update to version 2.14

I was just working on this! You beat me to it. Before I go making further changes, let me tell you about them and see what you think.


>  depends_lib         port:jpeg \

libpixman is now required; dependency needs to be added:

path:lib/pkgconfig/pixman-1.pc:libpixman


> @@ -33,11 +36,13 @@ use_configure no
> 
>  build.target        exiftran
>  build.args          verbose=yes \
>                      CC="${configure.cc}" \
> -                    EXTRA_CFLAGS="${configure.cflags} [get_canonical_archflags cc]"
> +                    EXTRA_CFLAGS="${configure.cflags} [get_canonical_archflags cc]" \
> +                    LIB="lib"
> +build.env-append    CC="${configure.cc}"


> + #!/bin/sh
> +-echo JPEG_LIB_VERSION | cpp $CFLAGS -include jpeglib.h | tail -1
> ++echo JPEG_LIB_VERSION | $CC -E $CFLAGS -include jpeglib.h - | tail -1

This will fail with old versions of clang that don't support CPATH. The intention here was probably for $CFLAGS to contain the -I flag, but we don't set it that way, nor do we even set CFLAGS as an environment variable. In my version, I had patched this to use $CPPFLAGS instead of $CFLAGS, and I had added an appropriate CPPFLAGS variable to build.env.






More information about the macports-dev mailing list