[macports-ports] branch master updated: exiftran: Update to version 2.14

[Ryan Schmidt]

On Sep 28, 2017, at 14:54, Ryan Schmidt wrote:

> On Sep 28, 2017, at 10:30, Rainer Müller wrote:
> 
>> Rainer Müller (raimue) pushed a commit to branch master
>> in repository macports-ports.
>> 
>> 
>> https://github.com/macports/macports-ports/commit/6b9c2b3be6d98ab37602690a9449bb688a0699e8
>> 
>> The following commit(s) were added to refs/heads/master by this push:
>> 
>>     new 6b9c2b3  exiftran: Update to version 2.14
> 
> I was just working on this! You beat me to it. Before I go making further changes, let me tell you about them and see what you think.
> 
> 
>> depends_lib         port:jpeg \
> 
> libpixman is now required; dependency needs to be added:
> 
> path:lib/pkgconfig/pixman-1.pc:libpixman

Also needs a build dependency on pkgconfig to be able to find libpixman.


>> + #!/bin/sh
>> +-echo JPEG_LIB_VERSION | cpp $CFLAGS -include jpeglib.h | tail -1
>> ++echo JPEG_LIB_VERSION | $CC -E $CFLAGS -include jpeglib.h - | tail -1
> 
> This will fail with old versions of clang that don't support CPATH. The intention here was probably for $CFLAGS to contain the -I flag, but we don't set it that way, nor do we even set CFLAGS as an environment variable. In my version, I had patched this to use $CPPFLAGS instead of $CFLAGS, and I had added an appropriate CPPFLAGS variable to build.env.

This script expects the jpeg version number to appear on the last line of cpp's output, but when using cpp, the last line was blank, and it was the last non-blank line that we wanted. I didn't try using $CC -E; instead, I replaced "tail -1" with "awk 'NF{p=$0} END{print p}'".