jmol haspatch maintainer - please commit #56106

[David Strubbe]

I committed it.

David

On Tue, Apr 3, 2018 at 12:40 PM, Peter Brommer <p.brommer at warwick.ac.uk>
wrote:

> Hi Mojca,
>
> thanks for the suggestion. In my defence, I’m following the (obviously
> out-of-date) guide at https://trac.macports.org/wiki/howto/Upgrade but
> I’ll try and use the pull requests for future updates. However, now that
> I’ve got your attention, could one of commit this patch one final time,
> even if it comes down the scenic route?
>
> Does trac remain in use for “proper” bug reports?
>
> Peter
>
> On 3 Apr 2018, at 17:28, Mojca Miklavec <mojca at macports.org> wrote:
>
> Dear Peter,
>
> On 3 April 2018 at 18:23, Peter Brommer wrote:
>
> Hi,
>
> I recently submitted a patch for jmol (as maintainer). Could somebody with
> commit privileges please take a look at https://trac.macports.org/
> ticket/56106 before it becomes outdated again…
>
>
> Just a suggestion (without taking a look at the ticket yet) ....
>
> While we did not really deprecate submissions via Trac, it turned out
> that we have one hyperactive team member who only watches pull
> requests on github and always makes sure that no more than 20 are open
> at any single moment, while the same cannot be said for Trac with long
> backlogs that many people don't notice.
>
> https://trac.macports.org/ticket/56051
>
> So ... I would suggest you to open a PR on GitHub to get this merged
> much faster.
>
> Mojca
>
>
> --
> Dr Peter Brommer
> Assistant Professor  |  Warwick Centre for Predictive Modelling  |  School
> of Engineering  |  University of Warwick
> p.brommer at warwick.ac.uk <pbrommer at warwick.ac.uk>  |
> www.warwick.ac.uk/pbrommer  |  External: +44 (0) 24 7652 8613  |
>  Internal: 28613
>
> D2.08  |  School of Engineering  | Library Road | Coventry  |  CV4 7AL  |
>  United Kingdom
>
> PGP Key: 2048R/B6DEA483 | Fingerprint: 5B6F F30A 9999 79C0 16CD 939E B406
> 9D2A B6DE A483
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.macports.org/pipermail/macports-dev/attachments/20180403/39bc10c8/attachment-0001.html>