port policy questions for munin

[Rainer Müller]

On 2018-04-04 01:38, macports at parvis.nl wrote:
> Questions about policy:
> - how to submit Portfile (unified diff against the previous version?)

If your new Portfile is significantly different from the previous
version, a unified diff would not be helpful. Just attach the full
Portfile in this case.

> - how to submit patch files (complete file as diff on diff is unreadable ?)

Indeed, attach the full patch files.

> - how to remove patch files (submit empty file + note in comment ?)

Just a note should do.

> - where to submit (in trac ?)

It is fine to attach a port update to a Trac ticket.

The preferred way, however, would be to submit a pull request against
the macports-ports repository on GitHub [1], as it offers automatic
checks and a better interface for reviewing.

> - port lint nitpicking complains about patchfile filenames, not ending in '.diff'. should i keep the previous names or change according to lint?
Please use either .diff or .patch, so syntax highlighting works
correctly when viewing the file.

As a side note, we had a recent discussion on relaxing the rules for
patchfile naming [2] and consensus seems to be that we no longer want to
require the patch-* prefix.

> - munin has 2 cron jobs: munin-node and munin-cron. currently munin-node is implemented as a normal startupitem, munin-cron (1.4.7 munin-update) as a separate file because StartInterval=300 isn't supported by macports startupitem. wouldn't it be more logical to use seperate files for both as that is more clear to the user? or perhaps create a real crontab?

Users would not care how the .plist files were created when the end
result is the same.

Using the startupitem.* in MacPorts for munin-node seems fine, as this
will automatically handle the interaction with launchd through daemondo.

> - munin stores html files in ${prefix}/www/munin. shouldn't that be /var/www/munin instead?

I do not have that directory on my system. Other ports are also using
${prefix}/www/ for HTML files.

$ ls -d /var/www
ls: /var/www: No such file or directory

Rainer

[1] https://github.com/macports/macports-ports/tree/master/net/munin
[2] https://lists.macports.org/pipermail/macports-dev/2018-March/037676.html