[macports-ports] branch master updated: webalizer: Remove negative variants - Use distname and worksrcdir instead of distfiles - Switch to db60 (latest version) - Add size to checksums - Sort dependencies

[mf2k at macports.org]

Hi Ryan,


Please go ahead and apply your patch, it is nomaintainer. I was just updating a long out of date and neglected port and trying to bring it up to our modern standards. Thanks for improving it further!


Cheers!
Frank

> On Jan 17, 2018, at 10:48 PM, Ryan Schmidt <ryandesign at macports.org> wrote:
> 
> 
> On Jan 17, 2018, at 11:13, Frank Schima wrote:
> 
>> Frank Schima (mf2k) pushed a commit to branch master
>> in repository macports-ports.
>> 
>> 
>> https://github.com/macports/macports-ports/commit/ca1a055075287abff4da1bdc3d2ef12a28313b95
>> 
>> The following commit(s) were added to refs/heads/master by this push:
>> 
>>     new ca1a055  webalizer: Remove negative variants  - Use distname and worksrcdir instead of distfiles  - Switch to db60 (latest version)  - Add size to checksums  - Sort dependencies
>> 
>> ca1a055 is described below
>> 
>> 
>> commit ca1a055075287abff4da1bdc3d2ef12a28313b95
>> 
>> Author: Frank Schima
>> AuthorDate: Wed Jan 17 10:13:33 2018 -0700
>> 
>> 
>>    webalizer: Remove negative variants
>>     - Use distname and worksrcdir instead of distfiles
>>     - Switch to db60 (latest version)
>>     - Add size to checksums
>>     - Sort dependencies
> 
> The change in dependencies warrants increasing the revision.
> 
> 
>> -variant with_bz2 description {Enable BZip2 decompression code       [default=no]} {
>> +variant with_bz2 description {Enable BZip2 decompression code} {
>>     configure.args-append   --enable-bz2
>>     depends_lib-append      port:bzip2
>> }
> 
> I'd like to see this variant removed and bzip2 support always enabled. bzip2 is a small dependency, and it's already guaranteed to be in the dependency chain anyway: webalizer depends on gd2 which depends on freetype which depends on bzip2.
> 
> 
>> -variant with_geoip conflicts no_dns description {Enable GeoIP geolocation code       [default=no]} {
>> +variant with_geoip conflicts no_dns description {Enable GeoIP geolocation code} {
>>     configure.args-append   --enable-geoip
>>     depends_lib-append      port:libgeoip
>> }
> 
> May as well do the same here. libgeoip is a tiny dependency that builds in about a minute and is distributable, so I see no great reason to make it optional.
> 
> If there's a great reason to keep the variant, then I'd like to see it renamed, removing "with_" from its name, and keeping a legacy compatibility variant.
> 
> 
>> +if {![variant_isset no_dns]} {
>> +    default_variants        +dns
>> +}
>> +
>> +if {![variant_isset no_largefile]} {
>> +    default_variants        +largefile
>> +}
> 
> In addition, if the user had requested the no_* variants, we want to preserve that by explicitly deselecting the corresponding new variant. Otherwise, once we remove the compatibility variants, the user will suddenly get those features enabled again.
> 
> See attached patch. Any objections?
> 
> <webalizer.diff>