[macports-ports] branch master updated: netperf: enable demo mode

[Ryan Schmidt]

On Jul 6, 2018, at 00:00, Eitan Adler wrote:

> Eitan Adler (grimreaper) pushed a commit to branch master
> in repository macports-ports.
> 
> 
> https://github.com/macports/macports-ports/commit/6935f6ab1cf8b99c9ca0cdaa2f8d03a5566b4e73
> 
> The following commit(s) were added to refs/heads/master by this push:
> 
>      new 6935f6a  netperf: enable demo mode
> 
> 6935f6a is described below
> 
> 
> commit 6935f6ab1cf8b99c9ca0cdaa2f8d03a5566b4e73
> 
> Author: Eitan Adler
> AuthorDate: Thu Jul 5 21:55:48 2018 -0700
> 
> 
>     netperf: enable demo mode
> 
>     
> 
>     Also fix the port to use github portgroup properly. The patch file is a
>     partial patch from 40c8a0f of the upstream repository.


> -# When updating this port to the next version, please return to correct usage of
> -# the github portgroup by removing the overrides for master_sites and worksrcdir.
>  github.setup        HewlettPackard netperf 2.7.0 netperf-
> +revision            1
>  categories          net
>  license             Noncommercial BSD BSD-old
> -platforms           darwin freebsd
> -maintainers         nomaintainer
> +platforms           darwin
> +maintainers         {grimreaper @grimreaper} openmaintainer
>  
>  description         a network performance benchmark
>  long_description    Netperf is a benchmark that can be used to measure \
> @@ -21,10 +20,14 @@ long_description    Netperf is a benchmark that can be used to measure \
>                      HP HiPPI LLA may be conditionally compiled-in.
>  
>  homepage            https://hewlettpackard.github.io/netperf/
> -master_sites        https://github.com/HewlettPackard/netperf/archive

Because you didn't wait until the next version to make this change, as was advised in the comment that you removed above, this is a stealth update. Because you didn't handle it as a stealth update (by changing dist_subdir and checksums), a checksum mismatch will now occur when our mirror is not used:

$ sudo port fetch --no-mirrors netperf && sudo port checksum netperf
--->  Fetching distfiles for netperf
--->  Attempting to fetch netperf-2.7.0.tar.gz from https://github.com/HewlettPackard/netperf/tarball/netperf-2.7.0
--->  Verifying checksums for netperf                                                        
Error: Checksum (rmd160) mismatch for netperf-2.7.0.tar.gz
Error: Checksum (sha256) mismatch for netperf-2.7.0.tar.gz
Error: Checksum (size) mismatch for netperf-2.7.0.tar.gz
Error: Failed to checksum netperf: Unable to verify file checksums
Error: See /opt/local/var/macports/logs/_Users_rschmidt_macports_macports-ports-svn-trunk_net_netperf/netperf/main.log for details.
Error: Follow https://guide.macports.org/#project.tickets to report a bug.
Error: Processing of port netperf failed

The simplest fix would be to revert the removal of master_sites, the removal of the comment, and the change of worksrcdir.


> +patchfiles          40c8a0fb873ac07a95f0c0253b2bd66109aa4c51.diff
> +
> +# openmaintainer does not apply to the configure argument. Talk with me before touching them.
> +configure.args      --enable-demo
>  
>  checksums           rmd160  ea5f83cce4bf03884c3c4ed3278146976627af0a \
>                      sha256  4569bafa4cca3d548eb96a486755af40bd9ceb6ab7c6abd81cc6aa4875007c4e \
>                      size    1993943
>  
> -worksrcdir          netperf-netperf-${version}
> +worksrcdir          netperf-netperf-${github.version}

This is still not correct usage of the github portgroup. Correct usage would be not specifying worksrcdir.