[macports-ports] branch master updated: libcaer: new port

[Mojca Miklavec]

On 1 March 2018 at 15:03, Ryan Schmidt wrote:
>
> On Mar 1, 2018, at 07:59, Perry E. Metzger wrote:
>> On Thu, 1 Mar 2018 07:48:35 -0600 Ryan Schmidt wrote:
>>>> +depends_lib-append  port:libusb
>>>
>>> The port failed to build without pkgconfig.
>>
>> Should the CI infrastructure have noticed that? I've kind of been
>> assuming that if CI is green you can assume the thing is okay, but
>> that's not the case it would seem?
>
> The builds failed on the buildbot, which is how I noticed the problem. On the buildbot, we activate the dependencies and then make sure the dependencies' build dependencies are deactivated before building the port, thus exposing the problem.

When exactly do we do that? I'm not aware of it. This is the script
being called:
    https://github.com/macports/mpbb/blob/master/mpbb-install-dependencies

I do remember some special handling of dependencies, but I fail to see
when the build dependencies would be deactivated.

We certainly remove dependencies between builds, but I'm not aware of
uninstallation of build dependencies. And in any case the go scripts
ultimately call mpbb, so if we change mpbb, it should automatically be
reflected in Travis as well.

> I see the build succeeded on Travis CI. I guess we don't do that same process on Travis CI. Whoever is handling our Travis CI stuff might want to look into that.

Here's the relevant log saying that 43 dependencies were installed,
including pkgconfig:
    https://travis-ci.org/macports/macports-ports/builds/347706617

In contrast our buildbot only installed 32:
    https://build.macports.org/builders/ports-10.13_x86_64-builder/builds/20139/steps/install-dependencies/logs/dependencies

I strongly suspect that the difference lies in non-distributability of
certain packages which need to be built on Travis first and thus
recursively depend on pkgconfig from some dependency and that
pkg-config is never deactivated. While the same package on the
buildbot slave has already been installed and never even activates
pkgconfig in the first place. I kind of suspect that if you started
with a fresh machine that would not have that dependency installed,
the build would most likely succeed on buildbot as well.

Mojca