[macports-base] 14/18: fetch: Remove svn.method option

Ryan Schmidt ryandesign at macports.org
Tue Mar 20 01:32:29 UTC 2018


Note: this commit is to the vcs-fetch branch, not to master.

On Mar 18, 2018, at 19:20, Rainer Müller wrote:

> Rainer Müller (raimue) pushed a commit to branch vcs-fetch
> in repository macports-base.
> 
> 
> https://github.com/macports/macports-base/commit/718a2072dad40298b01285de418edf5d9682b5da
> 
> commit 718a2072dad40298b01285de418edf5d9682b5da
> 
> Author: Rainer Müller
> AuthorDate: Mon Mar 19 00:37:00 2018 +0100
> 
>     fetch: Remove svn.method option
>     
>     The executed command should not be configurable, as it is defined by the
>     fetch code. Other methods could interfere the tarball creation.

Obviously, this will break the ports that currently override svn.method.


$ find . -name Portfile|xargs grep -E '^[[:space:]]*svn\.((pre_|post_)?args|method)(-append|-delete|-replace)?'
./games/PCLauncher/Portfile:svn.method                  checkout
./graphics/netpbm/Portfile:svn.method          checkout
./graphics/netpbm/Portfile:svn.post_args-append \
./graphics/netpbm/Portfile:    svn.args-replace    ${svn.method} update
./graphics/netpbm/Portfile:    svn.args-replace    ${svn.url} -r${svn.revision}
./graphics/netpbm/Portfile:    svn.args-append     advanced userguide
./graphics/netpbm/Portfile:    svn.post_args-delete \
./irc/irssi-devel/Portfile:svn.method          checkout
./lang/rpcgen-mt/Portfile:svn.pre_args-append --ignore-keywords
./science/emergent/Portfile:svn.args        --username anonymous --password emergent
./science/emergent/Portfile:svn.method      checkout
./science/flashdot/Portfile:svn.method        checkout


netpbm is the most complicated one, tweaking the arguments and commands in order to first check out a sparse working copy and then to update only the two directories we want. I do intend to switch netpbm over to downloading from a GitHub mirror instead, which will leave only a few much simpler cases to deal with, but I'll be sad to see the flexibility of fetching from svn in MacPorts reduced.




More information about the macports-dev mailing list