Pull Request Etiquette

[Helmut K. C. Tessarek]

Hello,

On 2018-05-20 00:06, Marcus Calhoun-Lopez wrote:
> Does anyone have any suggestions on the proper way forward?

It's a PR, you are the owner. Rebase and force push.

Unless there's a reason to keep the history there's no reason why not to
force push.

> It seems inefficient to attempt to describe the changes in the current pull request comment section.

It depends. Is there a reason to keep the process of getting where you
are right now alive?

> It seems a little silly to open a competing pull request.

Yes. Unless you close the previous one.

> Should I create a pull request on the pull request?

No.

I'm not a MacPorts dev so my opinion has not much weight, but I do know
how to work with git and in a team.

Cheers,
 K. C.


-- 
regards Helmut K. C. Tessarek              KeyID 0x172380A011EF4944
Key fingerprint = 8A55 70C1 BD85 D34E ADBC 386C 1723 80A0 11EF 4944

/*
   Thou shalt not follow the NULL pointer for chaos and madness
   await thee at its end.
*/

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.macports.org/pipermail/macports-dev/attachments/20180520/3ddb1d03/attachment-0001.sig>