[macports-ports] branch master updated: charls: initial commit

[Ryan Schmidt]

On May 20, 2018, at 12:55, Vincent wrote:

> Vincent (Veence) pushed a commit to branch master
> in repository macports-ports.
> 
> 
> https://github.com/macports/macports-ports/commit/e20fd1d6c0ea4426f9c0f73261b9669fc41a7252
> 
> The following commit(s) were added to refs/heads/master by this push:
> 
>      new e20fd1d  charls: initial commit
> 
> e20fd1d is described below
> 
> 
> commit e20fd1d6c0ea4426f9c0f73261b9669fc41a7252
> 
> Author: Veence
> AuthorDate: Sun May 20 19:55:05 2018 +0200
> 
> 
>     charls: initial commit



> +worksrcdir          team-charls-charls-6fa4f2b

You should remove this line. The github portgroup handles this for you.


> +# Must have XCode > 6 for C++14 support
> +minimum_xcodeversions {13 6.0 14 6.0} 

Instead of using the xcodeversions portgroup, you should blacklist the versions of compilers that don't support C++14. This allows MacPorts to pick a compiler that does support it, rather than just telling the user their Xcode is incompatible. From memory, I believe the code is:

PortGroup compiler_blacklist_versions 1.0
compiler.blacklist-append {clang < 602}