Commit History vs User Convenience
Marcus Calhoun-Lopez
mcalhoun at macports.org
Mon Oct 8 14:13:09 UTC 2018
I was hoping to get some help with how best to balance commit history and user convenience.
I would like to make two unrelated changed to the GCC ports.
Each change requires a revision increase of all the GCC ports.
There seem to be a few options:
1) Create two separate pull requests and have them merged separately.
2) Create one pull request that increases the revision number only once for the two unrelated changes.
3) Create one pull request with several commits. Each commit increases the revision number (for a total of two).
Personally, I believe option 3 is the best choice.
The history remains clean, and nobody has to rebuild GCC twice in a matter of a few days.
I have created such a pull request (https://github.com/macports/macports-ports/pull/2730).
However, the comments in the PR seem to indicate that option 2 or 3 is preferable.
I was hoping to see if others had any strong feelings about this.
Ultimately, it makes little difference to me, but we have had concerns in the past about frequent rebuilds of large ports such as GCC.
Thanks,
Marcus
More information about the macports-dev
mailing list