Merging pull requests before 72 hours

Christopher Jones jonesc at hep.phy.cam.ac.uk
Thu Oct 18 20:18:35 UTC 2018


>> 
>> That is understood. Either we allow ‘minor’ version updates directly, and accept that there will always be disagreements on what this means exactly, and sometimes a ‘minor’ update will be made that turns out not to be so minor, or we don’t allow any version updates under the ‘minor’ tag, and accept the additional work as members that *every* update has to then go via a PR. The guide also could perhaps be improved to be a bit more explicitly on what minor means. For instance, if we agree that includes minor version updates, then that should be stated.
> 
> Okay, then we should clarify that...
> Any suggestion on how it should be phrased?

Beyond the above, not really. If it is indeed agreed that some package version updates are allowed under the ‘minor’ tag, then I think the best you can do is just state that, and acknowledge that the determination of what is or is not a minor package revision cannot be quantified in generality, so is up to the member to decide making the changes, and that disagreements are inevitable.

Or, we decide no package version updates are allowed.

Chris

> 
> Rainer

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 1930 bytes
Desc: not available
URL: <http://lists.macports.org/pipermail/macports-dev/attachments/20181018/a2ac0101/attachment.bin>


More information about the macports-dev mailing list