Meson 0.56.2 and Python39

Ken Cunningham ken.cunningham.webuse at gmail.com
Tue Feb 2 23:30:33 UTC 2021


I will try it.

If I might say — I would expect that anyone submitting a PR has at least built the software on their local system, and used it enough to be sure it at least basically works, if not ran the whole test suite.

SO — meson must have worked properly on at least the system that was used to submit the PR.

I will (and do) thoroughly test the PRs and commits I personally do — which is why the cctools and libmacho and other updates take as long as they do.

I have been reviewing, looking over the changes, checking to build logs and checking the installed files on the PRs before I commit them.

Sometimes, I miss things — out of 150 PRs committed, Ryan and Josh have found corrections (revbumps, etc) in three or four. So I accept that rate.

But I do not expect to find massive broken changes submitted as PRs (we have been seeing some of that at times, hopefully I caught most of it), or otherwise wholly untested PRs that are thrown up without even a passing local build.

That is asking too much of PR reviewers to have absolutely no trust in the PR submitters.

Ken






> On Feb 2, 2021, at 2:32 PM, Craig Treleaven <ctreleaven at cogeco.ca> wrote:
> 
> Hi:
> 
> It might be that the meson update and/or the switch to python39 has broken builds on older Mac OS versions.  Specifically, I updated dav1d to 0.8.1 and it no longer configures successfully on 10.9 and older versions.  Upstream says that the now-failing configure test (a simple test to see if the compiler can create an executable) has not changed.  
> 
> Am I the only one seeing this?
> 
> The meson project doesn’t seem to have a change log and I haven’t waded through all of the commits between versions.  Is there a test suite with meson?  Have we checked it?  
> 
> Tomorrow, I think I’m going to try to bring up some VM’s and see if meson-log.txt has anything interesting on a failing OS version.
> 
> Craig



More information about the macports-dev mailing list