latest git version no longer detected by base

[Joshua Root]

On 2022-4-14 23:56 , Christopher Jones wrote:
> Hi All,
> 
> Does anyone have any ideas on
> 
> https://github.com/macports/macports-ports/commit/053dbb666a57972ceefba10b1edd12f16d886fd4#commitcomment-71271508 
> <https://github.com/macports/macports-ports/commit/053dbb666a57972ceefba10b1edd12f16d886fd4#commitcomment-71271508>
> 
> 
> something about the latest git port is causing it to no longer to 
> properly detected and used by base..

The git used by port sync is whatever is found by macports::findBinary: 
<https://github.com/macports/macports-base/blob/v2.7.2/src/macports1.0/macports.tcl#L2603>

And that ends up calling binaryInPath, which simply looks for an 
executable file of the given name in each directory in PATH: 
<https://github.com/macports/macports-base/blob/v2.7.2/src/macports1.0/macports.tcl#L407>

FWIW, my syncs still use /opt/local/bin/git after upgrading.

- Josh