[macports/macports-ports] abcde: switch to Perl 5.34 (PR #13720)

[Gabriel Rosenkoetter]

Probably belaboring the git history with this conversation further is 
unnecessary.

After some local frustrations (see also macports-user), I just ripped a 
CD successfully with abcde reinstalled per Christopher's (minimal, of 
course) patch, with perl5.34 on the system (and pointed to by 
/opt/local/bin/perl).

I'm hazy on current MacPorts git etiquette. Any reason I shouldn't just 
push "merge"?

Was my response to this overkill?

Do you (anybody) also think the CI/CD chain ought to include a "actually 
functions" step?

(Granted: that's a Big Drag for ports that depend on the presence of 
external media to test, as abcde does, and writing the test for the 
output here is complicated, since even if one were to load the build 
boxes with a CD with a single track a second long of a square wave, and 
run with the same abcde.conf every time, the output file probably 
wouldn't diff(1) against a prior sample, even with no software changes, 
so maybe just "ran without complaining" is enough. But even *that* kinda 
sucks.)

Aside: although I'm included as a maintainer for the abcde port 
(because, I think, years ago I submitted code to the upstream source to 
get it working on macOS, and then either refreshed or created the port), 
I… honestly don't remember where it ends up calling Perl (the main 
thing's just a Bash script, but it uses various software to read from 
devs and encode and then write out files). Blah blah blah 
https://www.ntia.gov/SBOM

On 2022-01-20 18:32 EST, Christopher Chavez wrote:
>     Shouldn't we be lint/building against macos-12 too?
> 
> Ideally, yes, but the CI provided by GitHub Actions does not yet 
> publicly offer macOS 12: actions/virtual-environments#3649 
> <https://github.com/actions/virtual-environments/issues/3649>
> 
> I’ve not personally checked this port on macOS 12, but it currently has 
> no known failures according to 
> https://ports.macports.org/port/abcde/builds/ 
> <https://ports.macports.org/port/abcde/builds/> so I expect it to work 
> after switching it to Perl 5.34 including on macOS 12.
> 
> —
> Reply to this email directly, view it on GitHub 
> <https://github.com/macports/macports-ports/pull/13720#issuecomment-1018019812>, 
> or unsubscribe 
> <https://github.com/notifications/unsubscribe-auth/ALBDZNCHGNTR5RKE6MGC2ELUXCLRHANCNFSM5MN4W7CQ>.
> Triage notifications on the go with GitHub Mobile for iOS 
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> 
> or Android 
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. 
> 
> You are receiving this because you were mentioned.Message ID: 
> <macports/macports-ports/pull/13720/c1018019812 at github.com>
> 


-- 
Gabriel Rosenkoetter (he/him)
gr at eclipsed.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 236 bytes
Desc: OpenPGP digital signature
URL: <http://lists.macports.org/pipermail/macports-dev/attachments/20220121/a6c31291/attachment.sig>