intltool random perls

[Craig Treleaven]

Hi:

I committed an update to the geany port today and it failed to build on several buildbots.  In reviewing the logs, I found that geany is using intltool and that various buildbots were trying to employ a different version of perl than that specified in the intltool portfile.  The intltool port was updated to perl5.30 in May 2021.

However, the logs from a selection of buildbots showed:

ports-12_arm64-builder
checking for perl... /usr/bin/perl
checking for perl >= 5.8.1… 5.30.3

ports-10_15_x86_64-builder
checking for perl... /usr/bin/perl
checking for perl >= 5.8.1… 5.18.4

ports-10_12_x86_64-builder
checking for perl... /opt/local/bin/perl
checking for perl >= 5.8.1… 5.28.3

etc…

The buildbots on OSX 10.12 and older are not finding a compatible version of XML::Parser and thus geany's configure fails.  However, NONE of the buildbots (nor my local machine) are using /opt/local/bin/perl5.30!

I believe we just need to pass a configure argument to intltool:

ac_cv_path_PERL=${prefix}/bin/perl${pbranch}

However, I’m surprised that this problem has apparently existed for many months without detection?  I have only a very rudimentary understanding of auto tools so maybe the problem is something very different?  Apparently there are 213 ports that have a build dependence on intltool so I don’t want to commit an erroneous fix.

Help?

Craig