[MacPorts] #18736: distname is not percent-encoded before gluing it into the URL

[MacPorts]

#18736: distname is not percent-encoded before gluing it into the URL
-------------------------------------+--------------------------------------
 Reporter:  ryandesign@…             |       Owner:  macports-tickets@…                   
     Type:  enhancement              |      Status:  new                                  
 Priority:  Normal                   |   Milestone:  MacPorts 1.8.0                       
Component:  base                     |     Version:  1.7.0                                
 Keywords:                           |        Port:                                       
-------------------------------------+--------------------------------------

Comment(by raimue@…):

 FYI ::http::* starts from the top level namespace, http::* looks for a
 http namespace in the current namespace first.

 Replying to [comment:5 ryandesign@…]:
 > formatQuery is for formatting a query string (e.g. "?a=b&c=d"), but
 that's not what we're doing, so I don't feel we should be using that
 function. It seems mapReply is the correct function to use.

 http::mapReply is private API (at least in 8.4 and 8.5, seems to have
 changed for 8.6), we '''should''' not use it. But we cannot even use it
 before we call another http::* function, as it is not listed in
 pkgIndex.tcl. http::formatQuery is a wrapper around http::mapReply which
 is public. Actually we want to encode a string to be used as value in a
 query string, so it is not absolutely wrong.

-- 
Ticket URL: <http://trac.macports.org/ticket/18736#comment:6>
MacPorts <http://www.macports.org/>
Ports system for Mac OS