[MacPorts] #18736: distname is not percent-encoded before gluing it into the URL

[MacPorts]

#18736: distname is not percent-encoded before gluing it into the URL
-------------------------------------+--------------------------------------
 Reporter:  ryandesign@…             |       Owner:  macports-tickets@…                   
     Type:  enhancement              |      Status:  new                                  
 Priority:  Normal                   |   Milestone:  MacPorts 1.8.0                       
Component:  base                     |     Version:  1.7.0                                
 Keywords:                           |        Port:                                       
-------------------------------------+--------------------------------------

Comment(by ryandesign@…):

 Replying to [comment:6 raimue@…]:
 > http::mapReply is private API (at least in 8.4 and 8.5, seems to have
 changed for 8.6), we '''should''' not use it. But we cannot even use it
 before we call another http::* function, as it is not listed in
 pkgIndex.tcl.
 That's a shame.

 > http::formatQuery is a wrapper around http::mapReply which is public.
 Actually we want to encode a string to be used as value in a query string,
 so it is not absolutely wrong.
 The [http://en.wikipedia.org/wiki/Query_string query string] is the part
 of a URL after the question mark. We are constructing a distfile URL which
 does not contain a question mark, meaning it does not have a query string
 component.

 So what about using curl_easy_escape() as you suggested?

-- 
Ticket URL: <http://trac.macports.org/ticket/18736#comment:7>
MacPorts <http://www.macports.org/>
Ports system for Mac OS