[MacPorts] #17191: Tix 8.4.3 - Tk Interface eXtension

MacPorts noreply at macports.org
Sat Mar 21 15:51:06 PDT 2009


#17191: Tix 8.4.3 - Tk Interface eXtension
------------------------------+---------------------------------------------
 Reporter:  krunk7@…          |       Owner:  macports-tickets@…                   
     Type:  enhancement       |      Status:  new                                  
 Priority:  Normal            |   Milestone:  Port Submissions                     
Component:  ports             |     Version:  1.6.0                                
 Keywords:                    |        Port:  Tix                                  
------------------------------+---------------------------------------------
Changes (by ryandesign@…):

 * cc: ryandesign@… (added)
  * port:  => Tix


Old description:

> From the home page:
> Tix, the Tk Interface eXtension, is a powerful set of user interface
> components that expands the capabilities of your Tcl/Tk and Python
> applications. Using Tix together with Tk will greatly enhance the
> appearance and functionality of your application.

New description:

 From the home page:[[br]]
   Tix, the Tk Interface eXtension, is a powerful set of user interface
 components that expands the capabilities of your Tcl/Tk and Python
 applications. Using Tix together with Tk will greatly enhance the
 appearance and functionality of your application.

--

Comment:

 There are several problems with the port as submitted.

  * The master_sites should just be "sourceforge" (efficiency issue; this
 way you get all the sourceforge mirrors instead of just the one you
 specified).
  * The distfiles line should be replaced with "distname
 ${name}${version}-src" (stylistic issue).
  * configure.args should not include --prefix=${prefix} (redundancy issue;
 MacPorts already puts --prefix=${prefix} in configure.pre_args for you).
  * The remaining configure args should use ${prefix} instead of /opt/local
 (accuracy issue; MacPorts may be in a different prefix).
  * I assume the entire pre-build block can be deleted; it's not
 appropriate for a port to call the port command to build another port.
 That's what dependencies are for, which this port already declares
 sufficiently.
  * The mixture of tabs and spaces should be replaced with all spaces
 (stylistic issue).
  * There should be an $Id$ line at the top (stylistic issue).

 I'll try fixing these issues and submitting a new port.

-- 
Ticket URL: <http://trac.macports.org/ticket/17191#comment:2>
MacPorts <http://www.macports.org/>
Ports system for Mac OS


More information about the macports-tickets mailing list