[MacPorts] #22288: Update Portfile: libfreespace 0.4

MacPorts noreply at macports.org
Tue Nov 10 17:20:55 PST 2009


#22288: Update Portfile: libfreespace 0.4
----------------------------------+-----------------------------------------
 Reporter:  burgess.jt@…          |       Owner:  ryandesign@…           
     Type:  update                |      Status:  assigned               
 Priority:  Normal                |   Milestone:                         
Component:  ports                 |     Version:                         
 Keywords:  haspatch maintainer   |        Port:  libfreespace           
----------------------------------+-----------------------------------------
Changes (by ryandesign@…):

  * owner:  macports-tickets@… => ryandesign@…
  * status:  new => assigned


Comment:

 In r60398 I committed a variation of your suggested change to the
 master_sites which should work even for release candidates and three-
 component version numbers.

 -----

 {{{
     file delete -force
 /System/Library/Extensions/FreespaceDeviceDriver.kext
     file copy ${worksrcpath}/osx/FreespaceDeviceDriver.kext
 /System/Library/Extensions/FreespaceDeviceDriver.kext
     file attributes /System/Library/Extensions/FreespaceDeviceDriver.kext
 -owner root -group wheel -permissions rwxr-xr-x
 }}}

 Ports should not install things outside the destroot. This should be
 changed to:

 {{{
     xinstall -d ${destroot}/System/Library/Extensions
     file copy ${worksrcpath}/osx/FreespaceDeviceDriver.kext
 ${destroot}/System/Library/Extensions
     file attributes
 ${destroot}/System/Library/Extensions/FreespaceDeviceDriver.kext -owner
 root -group wheel -permissions rwxr-xr-x
 }}}

 The port should also indicate that the fact that it violates the mtree is
 intentional:

 {{{
 destroot.violate_mtree yes
 }}}

 -----

 {{{
     touch /System/Library/Extensions.mkext
 }}}

 I assume with this line you're trying to force the kext cache to rebuild?
 [http://lists.apple.com/archives/usb/2002/Jan/msg00192.html This article]
 says touching /System/Library/Extensions is the better future-proof way to
 do that -- though that page is from 2002. If you have more recent
 information that contradicts that, please let me know.

 -----

 So that we can more easily see what was changed, it is be better to submit
 a patch rather than a full Portfile. I'm attaching
 [attachment:libfreespace.diff a patch] of my proposed changes. Do they
 look ok to commit?

-- 
Ticket URL: <http://trac.macports.org/ticket/22288#comment:2>
MacPorts <http://www.macports.org/>
Ports system for Mac OS


More information about the macports-tickets mailing list