[MacPorts] #27183: soci 3.0.0 Port Submission

[MacPorts]

#27183: soci 3.0.0 Port Submission
----------------------------------------+-----------------------------------
 Reporter:  markus@…                    |       Owner:  macports-tickets@…                   
     Type:  submission                  |      Status:  new                                  
 Priority:  Normal                      |   Milestone:                                       
Component:  ports                       |     Version:  1.9.1                                
 Keywords:                              |        Port:  soci                                 
----------------------------------------+-----------------------------------
Changes (by ryandesign@…):

  * port:  => soci


Comment:

 Some comments:

 {{{
 default_variants        +mysql +postgresql
 }}}
 There is no variant called "postgresql". However, "default_variants
 +mysql" would be ok if you want users to have MySQL support by default.

 {{{
 configure.args          --include-prefix=${destroot}/${prefix}/include \
                         --lib-prefix=${destroot}/${prefix}/lib
 }}}
 There should not be a slash before ${prefix} because ${prefix} already
 begins with a slash. However, are you sure these lines are necessary at
 all?

 {{{
         depends_lib-append port:mysql5-devel
 }}}
 Please depend on the stable port mysql5, not the development version in
 mysql5-devel. Also please write the dependency so that a user who wants to
 use mysql5-devel can do so. Refer to any existing port that depends on
 mysql5 for the correct way to write this dependency using the "path:"
 style.

 {{{
                 --postgresql-include=${prefix}/include/postgresql \
                 --postgresql-lib=${prefix}/lib/postgres
 }}}
 I don't think any of the PostgreSQL variants are correct because the
 directories they indicate for includes and libraries don't exist.

 {{{
     default_variants +postgresql83
 }}}
 Why not use postgresql90 as the default, since that is the latest stable
 version of PostgreSQL?

-- 
Ticket URL: <https://trac.macports.org/ticket/27183#comment:1>
MacPorts <http://www.macports.org/>
Ports system for Mac OS