[MacPorts] #28956: TortoiseHg Port Submission

MacPorts noreply at macports.org
Wed Apr 6 11:06:26 PDT 2011


#28956: TortoiseHg Port Submission
----------------------------------------+-----------------------------------
 Reporter:  guidolorenz@…               |       Owner:  macports-tickets@…                   
     Type:  submission                  |      Status:  new                                  
 Priority:  Normal                      |   Milestone:                                       
Component:  ports                       |     Version:                                       
 Keywords:  mercurial                   |        Port:                                       
----------------------------------------+-----------------------------------

Comment(by guidolorenz@…):

 Hi Shiena,

 thanks for your input. I had a look at your changes and have a few
 questions and comments:

  1. Copying the license file and building the english documentation is a
 good idea.
  1. Also building czech and japanese documentation seems a bit too much to
 me. I'm not sure, though -- is there a MacPorts best practice for dealing
 with localized documentation?
  1. Why do you manually create a symlink for thg in ${prefix}/bin? For me,
 the python26 port group already created this symlink automatically.
  1. I'm not a big fan of patch files -- instead of patching doc/Makefile,
 what do you think of calling make like this: {{{make SPHINXBUILD=sphinx-
 build-2.6 html}}}
  1. Why do we need config.py? To me it seemed like the auto-detection
 mechanisms worked fine. If we want to use a custom config.py, we must
 replace the hardcoded "/opt/local" by the value of ${prefix}.

 Cheers,
 Guido

-- 
Ticket URL: <https://trac.macports.org/ticket/28956#comment:2>
MacPorts <http://www.macports.org/>
Ports system for Mac OS


More information about the macports-tickets mailing list