[MacPorts] #37247: py27-cairo @1.10.0 Error: reinplace: couldn't read file Makefile.in

[MacPorts]

#37247: py27-cairo @1.10.0 Error: reinplace: couldn't read file Makefile.in
-------------------------------+--------------------------------
  Reporter:  nonstop.server@…  |      Owner:  macports-tickets@…
      Type:  defect            |     Status:  new
  Priority:  Normal            |  Milestone:
 Component:  ports             |    Version:  2.1.2
Resolution:                    |   Keywords:  leopard
      Port:  py27-cairo        |
-------------------------------+--------------------------------

Comment (by sean.michael.farley@…):

 Replying to [comment:1 ryandesign@…]:
 > That's because the port has this block:
 >
 > {{{
 >     platform darwin 9 {
 >         post-patch {
 >            reinplace "s| -export-symbols-regex.*||g"
 ${worksrcpath}/cairo/Makefile.in
 >         }
 >     }
 > }}}
 >
 > So those of us not on Leopard would not have seen this issue.
 >
 > Looking through the source, here are the only places where "`-export-
 symbols-regex`" now occurs:
 >
 > {{{
 > $ grep -r -- -export-symbols-regex work/
 > work/py2cairo-1.10.0/libtool:  -export-symbols-regex REGEX
 > work/py2cairo-1.10.0/libtool:      -export-symbols | -export-symbols-
 regex)
 > work/py2cairo-1.10.0/ltmain.sh:  -export-symbols-regex REGEX
 > work/py2cairo-1.10.0/ltmain.sh:      -export-symbols | -export-symbols-
 regex)
 > work/py2cairo-1.10.0/src/Makefile.am:_cairo_la_LDFLAGS = -module -avoid-
 version -export-symbols-regex init_cairo
 > work/py2cairo-1.10.0/src/Makefile.in:_cairo_la_LDFLAGS = -module -avoid-
 version -export-symbols-regex init_cairo
 > }}}
 >
 > So perhaps the reinplace needs to be changed to operate on
 src/Makefile.in instead (or better yet turned into a patchfile). Or maybe
 the reinplace is no longer needed at all; it has been there a long time,
 since r33474, having been copied there from py25-cairo, where it was added
 in r32471. Someone on Leopard could test without this block…

 Ryan, you are correct. I copied this code block from the previous
 portfiles but couldn't test it since I didn't have Leopard at the time.
 So, I thought better safe than sorry to leave it in. If it works without
 it then by all means commit it. Yay for code removal!

-- 
Ticket URL: <https://trac.macports.org/ticket/37247#comment:3>
MacPorts <http://www.macports.org/>
Ports system for Mac OS