[MacPorts] #37395: tk +x11: bad install_name for libtk8.6.dylib

[MacPorts]

#37395: tk +x11: bad install_name for libtk8.6.dylib
------------------------------+--------------------------------
  Reporter:  Peter_Dyballa@…  |      Owner:  macports-tickets@…
      Type:  defect           |     Status:  new
  Priority:  Normal           |  Milestone:
 Component:  ports            |    Version:  2.1.2
Resolution:                   |   Keywords:
      Port:  tk               |
------------------------------+--------------------------------

Comment (by ryandesign@…):

 In unix/configure.in we have:

 {{{
 LIB_RUNTIME_DIR='$(libdir)'
 }}}

 And then later:

 {{{
 if test "x${x_libraries}" != "x"; then
   if test "x${x_libraries}" != "xNONE"; then
     LIB_RUNTIME_DIR="${LIB_RUNTIME_DIR}:${x_libraries}"
   fi
 fi
 if test "${TCL_LD_SEARCH_FLAGS}" = '-L${LIB_RUNTIME_DIR}'; then
     LIB_RUNTIME_DIR=`echo ${LIB_RUNTIME_DIR} |sed -e 's/:/ -L/g'`
 fi
 }}}



 In unix/Makefile.in we have:

 {{{
 TK_SHLIB_LD_EXTRAS      = @TK_SHLIB_LD_EXTRAS@
 }}}

 After configure runs, this gets expanded in unix/Makefile to:

 {{{
 TK_SHLIB_LD_EXTRAS      = -compatibility_version 8.6 -current_version
 8.6.0 -install_name "${DYLIB_INSTALL_DIR}/${TK_LIB_FILE}" -sectcreate
 __TEXT __info_plist Tk-Info.plist
 }}}

 And then later in that file we have:

 {{{
 DYLIB_INSTALL_DIR       = ${LIB_RUNTIME_DIR}
 }}}



 This certainly seems to be a bug in the tk build system. It should be
 [https://sourceforge.net/tracker/?func=browse&group_id=12997&atid=112997
 reported to the developers of tk].

 --------

 For our purposes in MacPorts, since we know that libdir and x_libraries
 will always be the same thing, we could just remove this block:

 {{{
 if test "x${x_libraries}" != "x"; then
   if test "x${x_libraries}" != "xNONE"; then
     LIB_RUNTIME_DIR="${LIB_RUNTIME_DIR}:${x_libraries}"
   fi
 fi
 }}}

-- 
Ticket URL: <https://trac.macports.org/ticket/37395#comment:19>
MacPorts <http://www.macports.org/>
Ports system for Mac OS