[MacPorts] #41734: Port file for bitpocket

[MacPorts]

#41734: Port file for bitpocket
---------------------------------+--------------------------------
  Reporter:  cedric.simillion@…  |      Owner:  macports-tickets@…
      Type:  submission          |     Status:  new
  Priority:  Normal              |  Milestone:
 Component:  ports               |    Version:  2.2.1
Resolution:                      |   Keywords:
      Port:  bitpocket           |
---------------------------------+--------------------------------

Comment (by ryandesign@…):

 Thanks. Some observations:

  * Checksums are only used when fetching a distfile, not when fetching
 from a repository. You should virtually never need to override a port's
 checksum phase.
  * Fetching from the head of a repository is not ok; you must fetch a
 specific commit or tag, so that the build is reproducible. You've set the
 version field to "1.0.0", so you should fetch whatever tag or commit
 corresponds to that version number, however I'm not sure if that version
 really exists: I only see a tag "v0.1.0" made two years ago. Have the
 developers not released a new version since then? Perhaps they should be
 encouraged to do so.
  * Is there a reason why you need to fetch from git, and cannot fetch a
 tarball instead? The most common reason to need to fetch from git is if
 this project uses submodules. Does it?
  * Does this program really use git at runtime, or did you only add the
 git-core dependency because you're fetching the source from git? If the
 latter, remove the dependency; MacPorts automatically adds fetch
 dependencies as needed.
  * Since this project is hosted at github, consider using the github
 portgroup and its "github.setup" procedure. See other ports that use this
 portgroup for examples of how to use it. Using this portgroup will fetch a
 tarball by default, set up the livecheck, etc.
  * Overriding the configure phase is wrong; if there is no configure step,
 use "use_configure no".
  * Overriding the build phase with an empty block is usually only done for
 ports that don't build anything. Is that the case here? Is bitpocket
 composed entirely of non-compiled files, such as shell scripts? If so, add
 "supported_archs noarch".
  * Overriding the test phase is unnecessary, since it's disabled by
 default.
  * The ${prefix} variable already begins with a slash; don't put an extra
 slash in front of it.

-- 
Ticket URL: <https://trac.macports.org/ticket/41734#comment:1>
MacPorts <http://www.macports.org/>
Ports system for OS X