[MacPorts] #41734: Port file for bitpocket

[MacPorts]

#41734: Port file for bitpocket
---------------------------------+--------------------------------
  Reporter:  cedric.simillion@…  |      Owner:  macports-tickets@…
      Type:  submission          |     Status:  new
  Priority:  Normal              |  Milestone:
 Component:  ports               |    Version:  2.2.1
Resolution:                      |   Keywords:
      Port:  bitpocket           |
---------------------------------+--------------------------------

Comment (by cedric.simillion@…):

 Replying to [comment:1 ryandesign@…]:

 Thanks a lot for your input and sorry for the late reply, I had a busy
 week! :-)

 > Thanks. Some observations:
 >
 >  * Checksums are only used when fetching a distfile, not when fetching
 from a repository. You should virtually never need to override a port's
 checksum phase.
 I removed the checksum overriding

 >  * Fetching from the head of a repository is not ok; you must fetch a
 specific commit or tag, so that the build is reproducible. You've set the
 version field to "1.0.0", so you should fetch whatever tag or commit
 corresponds to that version number, however I'm not sure if that version
 really exists: I only see a tag "v0.1.0" made two years ago. Have the
 developers not released a new version since then? Perhaps they should be
 encouraged to do so.
 No, they did not release a new version, the most recent commit is from 8
 months ago. I modified to port file to use this specific commit. I've kept
 the version field in the port file to 1.0.0 as I am not sure what the
 actual version of the git repo is.

 >  * Is there a reason why you need to fetch from git, and cannot fetch a
 tarball instead? The most common reason to need to fetch from git is if
 this project uses submodules. Does it?
 It does not use submodules, but AFAIK, there is no tarball available
 containing the latest download.

 >  * Does this program really use git at runtime, or did you only add the
 git-core dependency because you're fetching the source from git? If the
 latter, remove the dependency; MacPorts automatically adds fetch
 dependencies as needed.
 Yes, bitpocket does (optionally) use git, so it's a bona fide  runtime
 dependency.

 >  * Since this project is hosted at github, consider using the github
 portgroup and its "github.setup" procedure. See other ports that use this
 portgroup for examples of how to use it. Using this portgroup will fetch a
 tarball by default, set up the livecheck, etc.
 Thanks for the tip. I tried using the github.setup routine, but this only
 seems to be fetching a tarball. As mentioned, there is no tarball
 available.

 >  * Overriding the configure phase is wrong; if there is no configure
 step, use "use_configure no".
 OK, done that.

 >  * Overriding the build phase with an empty block is usually only done
 for ports that don't build anything. Is that the case here? Is bitpocket
 composed entirely of non-compiled files, such as shell scripts? If so, add
 "supported_archs noarch".
 Bitpocket is indeed entirely non-compiled. In fact, it's just a fancy bash
 script. The reason that I am submitting it as a Portfile is that it needs
 some patching in order to work on OS X

 >  * Overriding the test phase is unnecessary, since it's disabled by
 default.
 OK, removed the test phase overriding

 >  * The ${prefix} variable already begins with a slash; don't put an
 extra slash in front of it.
 Oops, fixed!

-- 
Ticket URL: <https://trac.macports.org/ticket/41734#comment:2>
MacPorts <http://www.macports.org/>
Ports system for OS X