[MacPorts] #44227: suricata 2.0.2

[MacPorts]

#44227: suricata 2.0.2
-----------------------------+--------------------------------
  Reporter:  mschamschula@…  |      Owner:  macports-tickets@…
      Type:  submission      |     Status:  new
  Priority:  Normal          |  Milestone:
 Component:  ports           |    Version:  2.3.1
Resolution:                  |   Keywords:
      Port:  suricata        |
-----------------------------+--------------------------------

Comment (by ryandesign@…):

 Thanks. Some initial comments:

  * The tabs should be converted to spaces to conform to the modeline. Make
 sure the columns line up and that indentations are at multiples of 4
 spaces.
  * I see a dependency on port:file. Does the port really use the `file`
 program, or does it use the magic library? If the latter, depend on
 port:libmagic.
  * I see an ipfw variant that only adds a configure arg to enable an
 optional feature. Having fewer variants is better. To that end, is there a
 reason why this optional feature shouldn't be enabled all the time?
  * I see a geoip variant. I haven't tested it yet, but make sure that the
 port does *not* use libgeoip if the geoip variant is *not* selected, even
 if the libgeoip port is already installed.
  * I see patches that add `#define HAVE_STRLCPY 1`. Is that correct for
 all versions of OS X? I thought that had only been added to OS X recently.
 Isn't that kind of `#define` supposed to get set in config.h by running
 `./configure`?
  * I see another patch that adds DESTDIR support. Have these issues been
 reported to the developers already? If so, include URLs to those bug
 reports. (I usually put them in the patchfiles themselves, in the first
 line.)

-- 
Ticket URL: <https://trac.macports.org/ticket/44227#comment:1>
MacPorts <http://www.macports.org/>
Ports system for OS X