[MacPorts] #47806: OpenCoarrays @1.0

[MacPorts]

#47806: OpenCoarrays @1.0
-------------------------------+--------------------------------
  Reporter:  fanfarillo.gcc@…  |      Owner:  macports-tickets@…
      Type:  submission        |     Status:  new
  Priority:  Normal            |  Milestone:
 Component:  ports             |    Version:  2.3.3
Resolution:                    |   Keywords:
      Port:  opencoarrays      |
-------------------------------+--------------------------------

Comment (by ryandesign@…):

 Replying to [comment:25 fanfarillo.gcc@…]:

 > Reading your message on the email I missed the attachment. I modified
 the tarball on the website and produced the new attached Portfile (I
 merged your changes too).
 >
 > It works for me locally; did I miss anything?

 I'll let Larry handle this port from here, but yes, your new portfile has
 several issues:
 * You reintroduced tabs into the portfile; only spaces should be used.
 * You re-added gcc5 as a library dependency, though it does not appear to
 be used.
 * You changed mpich-gcc5 back to a library dependency, though it only
 appears to be needed at build time.
 * You changed `configure.cc` from the default `clang` to `mpicc-mpich-
 gcc5`, but clang had worked for me. Why change it? If changing it is
 important, use the absolute path.
 * You changed `configure.cxx` from the default `clang++` to `mpicxx-mpich-
 gcc5`, but this project's Makefiles don't seem to use `$(CXX)` so this is
 irrelevant.
 * You changed `configure.cpp` from the default `clang -E` to `mpic
 ++-mpich-gcc5`, which is a symlink to `mpicxx-mpich-gcc5` and is a
 conceptual mismatch. `configure.cpp` is meant to be the C preprocessor,
 not the C++ compiler, but again it's irrelevant because the Makefiles
 don't appear to use `$(CPP)`.
 * You used `set` to set options, which don't need `set` to set them.
 (`set` is only used for variables, not options.)
 * You removed the `MPICC` build argument I had set, thereby reintroducing
 the problem that setting it had fixed: namely, that the Makefile tries to
 run `mpicc` which does not exist.

-- 
Ticket URL: <https://trac.macports.org/ticket/47806#comment:27>
MacPorts <https://www.macports.org/>
Ports system for OS X