[MacPorts] #47806: OpenCoarrays @1.0
MacPorts
noreply at macports.org
Wed Jun 17 07:01:50 PDT 2015
#47806: OpenCoarrays @1.0
-------------------------------+--------------------------------
Reporter: fanfarillo.gcc@… | Owner: macports-tickets@…
Type: submission | Status: new
Priority: Normal | Milestone:
Component: ports | Version: 2.3.3
Resolution: | Keywords:
Port: opencoarrays |
-------------------------------+--------------------------------
Comment (by fanfarillo.gcc@…):
Replying to [comment:27 ryandesign@…]:
> Replying to [comment:25 fanfarillo.gcc@…]:
>
> > Reading your message on the email I missed the attachment. I modified
the tarball on the website and produced the new attached Portfile (I
merged your changes too).
> >
> > It works for me locally; did I miss anything?
>
> I'll let Larry handle this port from here, but yes, your new portfile
has several issues:
> * You reintroduced tabs into the portfile; only spaces should be used.
> * You re-added gcc5 as a library dependency, though it does not appear
to be used.
> * You changed mpich-gcc5 back to a library dependency, though it only
appears to be needed at build time.
Yes, Damian explained what we plan to do with compilers different from
gcc5. Currently, if a user wants to use opencoarrays has to use gcc5 or
gcc6. Declaring gcc5/gcc6 and mpich-gcc5 as dependencies allows the users
to download all the stuff needed to run a coarray program.
It is just an easy way to get all you need with a simple "sudo port
install opencoarrays". As Damian said, I am pretty new of the Mac and
MacPorts world so, if my reasoning violates rules about dependencies, I'll
be glad to find a different way to do it.
> * You changed `configure.cc` from the default `clang` to `mpicc-mpich-
gcc5`, but clang had worked for me. Why change it? If changing it is
important, use the absolute path.
> * You changed `configure.cxx` from the default `clang++` to `mpicxx-
mpich-gcc5`, but this project's Makefiles don't seem to use `$(CXX)` so
this is irrelevant.
> * You changed `configure.cpp` from the default `clang -E` to `mpic
++-mpich-gcc5`, which is a symlink to `mpicxx-mpich-gcc5` and is a
conceptual mismatch. `configure.cpp` is meant to be the C preprocessor,
not the C++ compiler, but again it's irrelevant because the Makefiles
don't appear to use `$(CPP)`.
I just read the instruction on UsingTheRightCompiler and forced to use
mpich for all the building process, I noticed the new Portfile when I was
about to upload mine...
> * You used `set` to set options, which don't need `set` to set them.
(`set` is only used for variables, not options.)
> * You removed the `MPICC` build argument I had set, thereby
reintroducing the problem that setting it had fixed: namely, that the
Makefile tries to run `mpicc` which does not exist.
I modified the Makefile in the library in order to manage this new
configuration. The library is composed by two .c files, one needs mpicc
and the other one doesn't. Currently I compile both files with mpicc-
mpich-gcc5.
--
Ticket URL: <https://trac.macports.org/ticket/47806#comment:28>
MacPorts <https://www.macports.org/>
Ports system for OS X
More information about the macports-tickets
mailing list