[MacPorts] #53548: Buildbot doesn't upload archives made distributable later

[MacPorts]

#53548: Buildbot doesn't upload archives made distributable later
----------------------------+---------------------
 Reporter:  ryandesign      |      Owner:  admin@…
     Type:  defect          |     Status:  new
 Priority:  Normal          |  Milestone:
Component:  server/hosting  |    Version:
 Keywords:  buildbot        |       Port:
----------------------------+---------------------
 Suppose a port is not distributable, because its license is not specified,
 but it builds successfully on the buildbot workers.

 Later, a commit indicates the port's license and it is now considered
 distributable.

 In portwatcher, mpbb analyzes the commit, sees that the port it modifies
 is already installed, and does not schedule a portbuilder task for that
 port, so the binary, though it is now distributable, is never uploaded to
 the rsync server.

 This is a consequence of fixing #52765.

 One solution could be the following pseudocode:

 {{{
 if the port is distributable and the archive is on the packages server
 then
     nothing to do
 else if the port is not distributable but the archive path exists on the
 buildworker's disk then
     nothing to do
 else
     build the port
 fi
 }}}

 This logic would be in two places: mpbb-install-dependencies and mpbb-
 install-port.

--
Ticket URL: <https://trac.macports.org/ticket/53548>
MacPorts <https://www.macports.org/>
Ports system for macOS