[MacPorts] #57822: cvs-fast-export: 'CLOCK_REALTIME' macro redefined, and different types ('int' vs 'enum clockid_t')

[MacPorts]

#57822: cvs-fast-export: 'CLOCK_REALTIME' macro redefined, and different types
('int' vs 'enum clockid_t')
------------------------------+----------------------
  Reporter:  ewenmcneill      |      Owner:  mojca
      Type:  defect           |     Status:  assigned
  Priority:  Normal           |  Milestone:
 Component:  ports            |    Version:
Resolution:                   |   Keywords:  mojave
      Port:  cvs-fast-export  |
------------------------------+----------------------

Comment (by ewenmcneill):

 Yes, it looks with that pull request patch manually applied it will now
 build and install on 10.14.2.

 {{{
 ewen at ashram:~$ uname -a
 Darwin ashram 18.2.0 Darwin Kernel Version 18.2.0: Mon Nov 12 20:24:46 PST
 2018; root:xnu-4903.231.4~2/RELEASE_X86_64 x86_64
 ewen at ashram:~$ port installed cvs-fast-export
 The following ports are currently installed:
   cvs-fast-export @1.44_0 (active)
 ewen at ashram:~$ cvs-fast-export --version
 cvs-fast-export: version 1.44
 ewen at ashram:~$
 }}}

 My understanding of the patch applied in ticket:52388 was that it was
 **preventing** the definition of "placeholder" `CLOCK_REALTIME`, etc,
 values, which was a work around needed on systems that did not have them
 to allow the build to succeed (but obviously not have "realtime"
 functionality; presumably lower granularity timing).  But macOS somewhere
 around 10.12 added `CLOCK_REALTIME`, etc, into the system includes.  Hence
 the patch to only define the placeholders on systems **without** them
 defined already.

 FWIW, I suspect this (patched by https://github.com/macports/macports-
 ports/pull/3294) version will probably be needed on 10.12, 10.13, and
 10.14.  (I went straight from 10.11 to 10.14 on this system, and have
 nothing not on 10.11 or 10.14 here now, so I can't test 10.12/10.13.)

 [https://github.com/macports/macports-ports/pull/3294 Upgrading to 1.44]
 seems to be sufficient, and presumably merged in upstream the patch that
 upstream came up with 18 months ago.

 Ewen

 PS: FTR, what I did to build this pull request:

 *   Download pull request as a unified diff from https://patch-
 diff.githubusercontent.com/raw/macports/macports-ports/pull/3294.diff

 *   Manually apply patch, and then build again:

 {{{
 ewen at ashram:~$ cd $(port dir cvs-fast-export)
 ewen at ashram:/opt/local/var/macports/sources/rsync.macports.org/release/tarballs/ports/devel
 /cvs-fast-export$ ls
 Portfile        files           work
 ewen at ashram:/opt/local/var/macports/sources/rsync.macports.org/release/tarballs/ports/devel
 /cvs-fast-export$ grep version Portfile
 version             1.43
 ewen at ashram:/opt/local/var/macports/sources/rsync.macports.org/release/tarballs/ports/devel
 /cvs-fast-export$ sudo patch -p3 <~/Desktop/cvs-fast-export.patch
 Password:
 patching file Portfile
 patching file files/patch-Makefile.diff
 ewen at ashram:/opt/local/var/macports/sources/rsync.macports.org/release/tarballs/ports/devel
 /cvs-fast-export$ grep version Portfile
 version             1.44
 ewen at ashram:/opt/local/var/macports/sources/rsync.macports.org/release/tarballs/ports/devel
 /cvs-fast-export$ cd
 ewen at ashram:~$ sudo port install cvs-fast-export
 Portfile changed since last build; discarding previous state.
 --->  Computing dependencies for cvs-fast-export
 --->  Fetching archive for cvs-fast-export
 --->  Attempting to fetch cvs-fast-export-1.44_0.darwin_18.x86_64.tbz2
 from https://packages.macports.org/cvs-fast-export
 --->  Attempting to fetch cvs-fast-export-1.44_0.darwin_18.x86_64.tbz2
 from http://sea.us.packages.macports.org/macports/packages/cvs-fast-export
 --->  Attempting to fetch cvs-fast-export-1.44_0.darwin_18.x86_64.tbz2
 from http://kmq.jp.packages.macports.org/cvs-fast-export
 --->  Fetching distfiles for cvs-fast-export
 --->  Attempting to fetch cvs-fast-export-1.44.tar.gz from
 http://aarnet.au.distfiles.macports.org/pub/macports/distfiles/cvs-fast-
 export
 --->  Attempting to fetch cvs-fast-export-1.44.tar.gz from
 https://distfiles.macports.org/cvs-fast-export
 --->  Attempting to fetch cvs-fast-export-1.44.tar.gz from
 http://sea.us.distfiles.macports.org/macports/distfiles/cvs-fast-export
 --->  Attempting to fetch cvs-fast-export-1.44.tar.gz from
 http://kmq.jp.distfiles.macports.org/cvs-fast-export
 --->  Attempting to fetch cvs-fast-export-1.44.tar.gz from
 http://www.catb.org/~esr/cvs-fast-export/
 --->  Verifying checksums for cvs-fast-export
 --->  Extracting cvs-fast-export
 --->  Applying patches to cvs-fast-export
 --->  Configuring cvs-fast-export
 --->  Building cvs-fast-export
 --->  Staging cvs-fast-export into destroot
 --->  Installing cvs-fast-export @1.44_0
 --->  Activating cvs-fast-export @1.44_0
 --->  Cleaning cvs-fast-export
 --->  Scanning binaries for linking errors
 --->  No broken files found.
 --->  No broken ports found.
 ewen at ashram:~$
 }}}

-- 
Ticket URL: <https://trac.macports.org/ticket/57822#comment:4>
MacPorts <https://www.macports.org/>
Ports system for macOS