[MacPorts] #55878: lowdown @0.3.1: Fix mandir; fix universal variant; fix build on Snow Leopard and earlier

[MacPorts]

#55878: lowdown @0.3.1: Fix mandir; fix universal variant; fix build on Snow
Leopard and earlier
-------------------------+----------------------
  Reporter:  ryandesign  |      Owner:  janstary
      Type:  defect      |     Status:  new
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:
Resolution:              |   Keywords:  haspatch
      Port:  lowdown     |
-------------------------+----------------------

Comment (by ryandesign):

 Replying to [comment:1 janstary]:
 > I agree that `--disable-dependency-tracking` should be dropped.
 > Indeed, lowdown's `./configure` only accepts certain KEY=VAL as its
 arguments.
 > So I think `configure.universal_args` should be cleared completely in
 fact.

 As you wish. `--disable-dependency-tracking` is the only thing in
 `configure.universal_args` at this time, so it makes no difference.

 > I attach a log of `port -vsd install lowdown` on my system (10.13):
 > I don't see the `--disable-dependency-tracking` added, perhaps that's
 why
 > it didn't fail for me. Why would it not added on my system?

 It is only added if you use the universal variant.

 > Why does the LDFLAGS need to be recognized in `./configure`?
 > Is there something we need to pass here to the lowdown build?
 > Without this patch, it gets compiled with
 > {{{
 > LDFLAGS='-L/opt/local/lib -Wl,-headerpad_max_install_names -arch x86_64'
 > }}}

 No, it does not use those flags. MacPorts tells the build system to use
 those flags, and the build system ignores that request. My patches fix the
 build system so that it respects the flags MacPorts tells it to use. This
 allows the universal variant to work correctly, for example, since the
 LDFLAGS are one of the places where MacPorts tells the build system what
 architectures to use.

 > Is there something else we need to pass? As of now, it seems
 > the only application is to have `-lsnowleopardfixes` added to the build.
 > I would like to get rid of that completely: lowdown goes out of its way
 > to be very portable and provides compatibility implementations for
 missing
 > functions in `compats.c` -- it's just that strndup(3) and strnlen(3)
 isn't there.
 > I talked to upstream: it seems much cleaner to just add these two
 functions
 > as opposed to tweaking the build and link to something else; they will
 add it soon.
 > We might either add them to `compats.c` for no until upstream does,
 > or just wait a bit for the next release which will have them
 > (upstream is quite responsive).

 Absolutely, it is better for upstream to provide the compatibility
 implementations. Until they do, including the snowleopard_fixes portgroup
 allows the port to build on Snow Leopard and earlier.

--
Ticket URL: <https://trac.macports.org/ticket/55878#comment:2>
MacPorts <https://www.macports.org/>
Ports system for macOS