[MacPorts] #58552: harfbuzz @2.5.1 does not build on PPC Leopard, Mac OS X 10.5.8, because some warnings being treated as errors

[MacPorts]

#58552: harfbuzz @2.5.1 does not build on PPC Leopard, Mac OS X 10.5.8, because
some warnings being treated as errors
------------------------+---------------------
  Reporter:  ballapete  |      Owner:  (none)
      Type:  defect     |     Status:  new
  Priority:  Normal     |  Milestone:
 Component:  ports      |    Version:  2.5.4
Resolution:             |   Keywords:  leopard
      Port:  harfbuzz   |
------------------------+---------------------

Comment (by ballapete):

 This failure,

 {{{
 hb-coretext.cc: In function 'hb_bool_t
 _hb_coretext_shape(hb_shape_plan_t*, hb_font_t*, hb_buffer_t*, const
 hb_feature_t*, unsigned int)':
 hb-coretext.cc:828:64: error: implicit conversion from 'CGFloat {aka
 float}' to 'double' to match other operand of binary expression [-Werror
 =double-promotion]
        advances_so_far -= CTLineGetTrailingWhitespaceWidth (line);
                                                                 ^
 }}}

 seems to be created by your patch.

 The function `CTLineGetTrailingWhitespaceWidth()` is declared in

 {{{
 # 329
 "/System/Library/Frameworks/ApplicationServices.framework/Frameworks/CoreText.framework/Headers/CTLine.h"
 3
 double CTLineGetTrailingWhitespaceWidth(
  CTLineRef line ) ;
 }}}

 so `advances_so_far` cannot be typecast as a `float`.

 I am going to patch your patch…

-- 
Ticket URL: <https://trac.macports.org/ticket/58552#comment:3>
MacPorts <https://www.macports.org/>
Ports system for macOS