[MacPorts] #59743: clamav-server: destroot patch failed

[MacPorts]

#59743: clamav-server: destroot patch failed
----------------------------+-----------------------
  Reporter:  ryandesign     |      Owner:  essandess
      Type:  defect         |     Status:  assigned
  Priority:  Normal         |  Milestone:
 Component:  ports          |    Version:  2.6.2
Resolution:                 |   Keywords:
      Port:  clamav-server  |
----------------------------+-----------------------

Comment (by ryandesign):

 Replying to [comment:3 essandess]:
 > I originally had line-by-line reinplace commands, but these were
 replaced by patch files in the review. See https://github.com/macports
 /macports-ports/pull/4587#discussion_r293100109

 Right, and the discussion there explained the advantage of patchfiles,
 including that exactly what is happening now will happen: that the patch
 will fail to apply if the file being patched changes. You want this, so
 that you have the opportunity to revise the patch in the appropriate way.
 If you had used reinplaces instead, this would not have happened and the
 port would have installed, even though the file being patched had changed
 in some way, possibly in a way that made the reinplaces fail to work
 properly. In this specific instance, I admit that it would not have made a
 difference, but that's no guarantee about what will happen with future
 changes. My guidance is in the ticket description.

-- 
Ticket URL: <https://trac.macports.org/ticket/59743#comment:6>
MacPorts <https://www.macports.org/>
Ports system for macOS