[MacPorts] #59743: clamav-server: destroot patch failed

[MacPorts]

#59743: clamav-server: destroot patch failed
----------------------------+-----------------------
  Reporter:  ryandesign     |      Owner:  essandess
      Type:  defect         |     Status:  assigned
  Priority:  Normal         |  Milestone:
 Component:  ports          |    Version:  2.6.2
Resolution:                 |   Keywords:
      Port:  clamav-server  |
----------------------------+-----------------------

Comment (by essandess):

 Thanks. I’m honestly still not convinced that patch files are the best
 approach in this specific scenario where the edits are all keyword/value
 settings in a {{{.conf}}} file. In this example, someone added a period to
 the end of a comment, and the whole thing breaks.

 But I’ll stick with patch files if that’s the consensus, and hopefully
 find a more robust way of using them.

 Do you or anyone know of a patch command settings that ignores comment
 lines?

 > My guidance is in the ticket description.

 I apologize, but I’m not conversant enough in MacPorts design to act on
 that description.

 What’s a {{{revbump}}}? What code or edits must take place to create it?

 What command should be used to create the patch file to avoid the issue
 you identified? I’m still not clear about the source of the patch file
 problem.


 Replying to [comment:6 ryandesign]:
 > Right, and the discussion there explained the advantage of patchfiles,
 including that exactly what is happening now will happen: that the patch
 will fail to apply if the file being patched changes. You want this, so
 that you have the opportunity to revise the patch in the appropriate way.
 If you had used reinplaces instead, this would not have happened and the
 port would have installed, even though the file being patched had changed
 in some way, possibly in a way that made the reinplaces fail to work
 properly. In this specific instance, I admit that it would not have made a
 difference, but that's no guarantee about what will happen with future
 changes. My guidance is in the ticket description.

-- 
Ticket URL: <https://trac.macports.org/ticket/59743#comment:7>
MacPorts <https://www.macports.org/>
Ports system for macOS