[MacPorts] #65354: iTerm2 @3.4.15_3: SafeAreaInsets are still breaking builds on older systems

[MacPorts]

#65354: iTerm2 @3.4.15_3: SafeAreaInsets are still breaking builds on older systems
----------------------+----------------------
  Reporter:  Gandoon  |      Owner:  markemer
      Type:  defect   |     Status:  assigned
  Priority:  Normal   |  Milestone:
 Component:  ports    |    Version:  2.7.2
Resolution:           |   Keywords:
      Port:  iTerm2   |
----------------------+----------------------

Comment (by Gandoon):

 Replying to [comment:12 kencu]:
 > getting there, yes! thanks so much.
 >
 > Indeed, macports prefers patches that are always applied, rather than
 conditional patches, for various reasons.
 >
 > you test for MAC_OS_X_VERSION_MAX_ALLOWED if are testing the SDK version
 (which you are wanting to do here). It’s a detail we don’t need to get
 into now.
 >
 > We can work with this, thanks!

 I am not quite sure what you mean here, I test for `#if
 MAC_OS_X_VERSION_MIN_REQUIRED >= 120000` not
 `MAC_OS_X_VERSION_MAX_ALLOWED`, as I just want the code to be there only
 on MacOS 12 or later. I may be misunderstanding exactly how these macros
 are meant to be used, and if so, I would be grateful for a quick breakdown
 of how they are supposed to be used. I was trying to find further
 documentation of them online, but I mainly found quite old references to
 the availability macros, say MacOS 10.12 or thereabouts.

 For information, I am building with an Xcode 12.4 build 12D4e. However, I
 am in fact doing so on a 10.15.7 system. The reason for this is that I
 have previously had some backward compatibility issues with some to
 MacPorts unrelated software that made me opt to not upgrade at the time.
 (I may upgrade at some point to 11, but that would be when I manage to
 acquire a new suitable backup drive.)

 This is the SDK configuration I have available at the moment:
 {{{
 $ xcodebuild -showsdks

 .   .   .

 macOS SDKs:
         DriverKit 20.2                  -sdk driverkit.macosx20.2
         macOS 11.1                      -sdk macosx11.1

 .   .   .

 }}}

 Unfortunately I do not have neither a 10.14 nor an 11 system to try this
 on live, but judging from the outcome on my 10.15 system and the fact that
 it is built with the 11.1 SDK, I hope it is not too far a stretch to
 expect it to work on MacOS 11. I guess there needs to be a few more of
 these tests yet for the older SDKs.

 Either way, thanks for pointing me towards the macro solution, I learnt
 something from this, and hopefully my input will solve issues for others
 going forward :)

-- 
Ticket URL: <https://trac.macports.org/ticket/65354#comment:15>
MacPorts <https://www.macports.org/>
Ports system for macOS