rtorrent: My first patch attempt

Ryan Schmidt ryandesign at macports.org
Thu Oct 11 22:15:24 PDT 2007


On Oct 11, 2007, at 12:44, Marcus D'Camp wrote:

> On Wed, Oct 10, 2007 at 10:05:46PM -0500, Ryan Schmidt wrote:
>
>> On Oct 10, 2007, at 19:16, Marcus D'Camp wrote:
>>
>>> I'll start with a little background.  I attempted to contact the
>>> maintainer about the port to be patched, but didn't get a response
>>> so I
>>> decided to take a more DIY approach since I wanted to learn more  
>>> about
>>> mac ports anyways.  The only thing to be done is upgrade the
>>> version and
>>> checksums.  I was just wondering if you guys could check my work
>>> before I look a fool posting it to trac, it seems like the diff
>>> file is
>>> a bit redundant. Here's a insert of
>>> diff -u Portfile.orig Portfile > Portfile-rtorrent.diff
>>
>> Then please submit a diff that only makes those changes. In
>> particular, your diff also appears to change the whitespace of the
>> entire file, which makes it very difficult to see what substantive
>> changes you're proposing.
>
> Strangely, I thought I had just done a cp of the original portfile  
> over
> to where I was working.  Some how the tab delimited structure of the
> portfile turned into just spaces.  No idea how that happened, fixed
> either way, thanks for taking a look.

Thanks. I see you also submitted the new diff in ticket 12895. I've  
assigned it to and Cc'ed the maintainer. If we don't hear from him  
within 3 days, I'll be happy to commit it.



More information about the macports-users mailing list