transcode 1.1.0 beta1 portfile with quicktime and lzo
Ryan Schmidt
ryandesign at macports.org
Wed Sep 3 22:53:57 PDT 2008
On Sep 2, 2008, at 3:54 PM, David Liontooth wrote:
> Ryan Schmidt wrote:
>
>> Yes, you should submit Portfile changes attached to tickets in the
>> issue tracker in the future. Pasting submissions into an email is not
>> optimal as email transport can sometimes add whitespace or rewrap
>> lines, plus emails can easily get forgotten. At least in the issue
>> tracker, they can be searched for and found.
>
> I used an attachment, but sure.
I noticed that later... my email client showed it inline which
confused me.
>> It's also best to submit changes as unified diffs, not as full
>> Portfiles. That way it's easier for both you and the committer to see
>> what you're changing. In the case of this port, you inadvertently
>> removed a crucial closing curly bracket in the imagemagick variant. I
>> fixed this before committing.
>
> Thanks! What's the diff command you use?
Just "diff -u" is fine. It's described in this part of the Guide:
http://guide.macports.org/#development.patches
>> May I also enable the port's parallel build, as requested earlier?
>>
>> http://lists.macosforge.org/pipermail/macports-users/2008-August/
>> 011141.html
>
> I did respond to this. I haven't tested it yet -- transcode builds
> fast
> anyway -- but sure, let's do it.
Done!
More information about the macports-users
mailing list