[86008] trunk/dports/graphics/wxWidgets-devel/Portfile

[Ryan Schmidt]

On Oct 18, 2011, at 03:26, and.damore at macports.org wrote:

> Revision: 86008
>          http://trac.macports.org/changeset/86008
> Author:   and.damore at macports.org
> Date:     2011-10-18 01:26:04 -0700 (Tue, 18 Oct 2011)
> Log Message:
> -----------
> port wxwdigets-devel: adding universal variant, darwin 11 only (i386, x86_64), close #31554, maintainer timeout
> 
> Modified Paths:
> --------------
>    trunk/dports/graphics/wxWidgets-devel/Portfile
> 
> Modified: trunk/dports/graphics/wxWidgets-devel/Portfile
> ===================================================================
> --- trunk/dports/graphics/wxWidgets-devel/Portfile	2011-10-18 08:22:46 UTC (rev 86007)
> +++ trunk/dports/graphics/wxWidgets-devel/Portfile	2011-10-18 08:26:04 UTC (rev 86008)
> @@ -7,7 +7,7 @@
> conflicts       wxgtk wxWidgets
> version         2.9.2
> revision        1
> -
> +license         wxWindow Licence 3.1

That's not the format licenses should be listed in. Using "port info --index --license license:wx" to see what other ports are using for this license, you probably want to write "license wxWindows-3.1"


> +    universal_variant yes
> +    variant universal {
> +        configure.args-append   --enable-universal_binary
> +
> +        #removing single arch target
> +        configure.cppflags-delete -arch ${configure.build_arch}
> +        
> +        #enabling the following breaks a cpp test while configuring
> +        #it's not needed as archs are hardcoded in configure script
> +#        configure.cppflags-append "-arch [join ${universal_archs} \ -arch\ ]"
> +
> +        #removing hardcoded ppc target as it won't build with XCode 4.1
> +        #this is required due the use of --enable-universal_binary
> +        #it could stay out of universal variant as ppc platform isn't supported in darwin 11
> +        post-patch {
> +            reinplace -- "s|-arch ppc ||" ${worksrcpath}/../configure
> +        }
> +    }

As I mentioned in the ticket, I'm not comfortable with a universal variant that hardcodes the architectures, nor one that's specific to an OS version. Why does this universal variant have to be specific to Lion? Why can't it respect the ${universal_archs} variable?